From d39d3ba79b53e0e6fa753722aa1a74ebc42ba484 Mon Sep 17 00:00:00 2001
From: Kaan Barmore-Genc <kaan@bgenc.net>
Date: Sun, 13 Aug 2023 11:56:53 -0500
Subject: [PATCH] add nextjs native module bindings error

---
 .devcontainer/devcontainer.json               |  9 +++-
 ...-property-indexof-undefined-getFileName.md | 49 +++++++++++++++++++
 2 files changed, 57 insertions(+), 1 deletion(-)
 create mode 100644 content/posts/2023.08.13.nextjs-bindings-cannot-read-property-indexof-undefined-getFileName.md

diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
index 33f8f2a..74e1bcb 100644
--- a/.devcontainer/devcontainer.json
+++ b/.devcontainer/devcontainer.json
@@ -11,7 +11,14 @@
   // Use 'forwardPorts' to make a list of ports inside the container available locally.
   "forwardPorts": [1313],
 
-  "onCreateCommand": "apk add git-lfs"
+"onCreateCommand": "apk add git-lfs",
+"customizations": {
+	"vscode": {
+		"extensions": [
+			"streetsidesoftware.code-spell-checker"
+		]
+	}
+}
 
   // Use 'postCreateCommand' to run commands after the container is created.
   // "postCreateCommand": "uname -a",
diff --git a/content/posts/2023.08.13.nextjs-bindings-cannot-read-property-indexof-undefined-getFileName.md b/content/posts/2023.08.13.nextjs-bindings-cannot-read-property-indexof-undefined-getFileName.md
new file mode 100644
index 0000000..b5d0288
--- /dev/null
+++ b/content/posts/2023.08.13.nextjs-bindings-cannot-read-property-indexof-undefined-getFileName.md
@@ -0,0 +1,49 @@
+---
+title: "Next.js error about native node modules using bindings"
+date: 2023-08-13T16:44:41Z
+toc: false
+images:
+tags:
+  - dev
+---
+
+This might be a little niche, but I had trouble finding anyone else write about
+it so I might as well.
+
+I was trying to use a native node module [libheif-node-dy](https://www.npmjs.com/package/libheif-node-dy) that uses [bindings](https://www.npmjs.com/package/bindings) in a Next.js app, and I kept getting errors from bindings:
+
+```
+- error node_modules/.pnpm/bindings@1.5.0/node_modules/bindings/bindings.js (179:15) @ indexOf
+- error Error [TypeError]: Cannot read properties of undefined (reading 'indexOf')
+    at Function.getFileName (webpack-internal:///(rsc)/./node_modules/.pnpm/bindings@1.5.0/node_modules/bindings/bindings.js:193:18)
+    at bindings (webpack-internal:///(rsc)/./node_modules/.pnpm/bindings@1.5.0/node_modules/bindings/bindings.js:130:52)
+```
+
+After a little digging, I came across [this Github issue by Nicholas Ramz](https://github.com/TooTallNate/node-bindings/issues/61) who diagnosed the issue down to the Webpack/Terser minimizer, which removes a line that looks like a no-op but is actually supposed to
+trigger an error stack. Bindings needs that to happen, otherwise you get this error.
+
+The solution he suggested is that you change your Webpack config to disable that
+Terser optimization. This is sounds like a good solution, but it's a bit hard to
+apply to Next.js because I don't have a webpack config of myself. Next.js has
+it's Webpack config built-in, and while it allows you to override it the
+documentation is a little bare.
+
+I found an easier solution for Next.js though: you can tell Next.js to not
+bundle a module. You can configure this with the
+`serverComponentsExternalPackages` option. My config file now looks like this:
+
+```js
+/** @type {import('next').NextConfig} */
+const nextConfig = {
+  experimental: {    
+    serverComponentsExternalPackages: ["libheif-node-dy"],
+  },
+};
+
+module.exports = nextConfig;
+```
+
+And this immediately worked, the module no longer gets bundled but instead
+executed like a regular node module, which gets around this issue. Since native
+modules can't be bundled into a JS file anyway, I don't think you lose much by
+disabling bundling just for native modules anyway.