kaan/MCAD-Library
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Merge pull request #70 from lordofhyphens/polyhole-centering

Browse source 
@nophead 's polyhole function could use a little more love and attention to make
it act a little more like cylinder.

This PR adds the center and r parameters, defaulting them to existing behavior
if they aren't specified.
This commit is contained in:
Chow Loong Jin 2020-03-29 23:23:34 +08:00
parent 9fd97fa52d bf2d04c279
commit 830ce58e41
1 changed files with 21 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
polyholes.scad
View file

@ -2,22 +2,28 @@
// This file is licensed under the terms of Creative Commons Attribution 3.0 Unported.
// Using this holes should come out approximately right when printed
module polyhole(h, d) {
n = max(round(2 * d),3);
module polyhole(h, d=0, r=0, center=false) {
_r = (r == 0 ? d / 2 : r);
_d = (d == 0 ? r * 2 : d);
n = max(round(2 * _d),3);
rotate([0,0,180])
cylinder(h = h, r = (d / 2) / cos (180 / n), $fn = n);
cylinder(h = h, r = (_d / 2) / cos (180 / n), $fn = n, center=center);
}
module test_polyhole(){
difference() {
cube(size = [100,27,3]);
union() {
for(i = [1:10]) {
translate([(i * i + i)/2 + 3 * i , 8,-1])
polyhole(h = 5, d = i);
d = i + 0.5;
assign(d = i + 0.5)
translate([(d * d + d)/2 + 3 * d, 19,-1])
polyhole(h = 5, d = d);
}
}
}
}